]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
gdmUtil: Fix SignalTracker leak in ShellUserVerifier
authorSebastian Keller <skeller@gnome.org>
Sun, 12 Feb 2023 17:20:15 +0000 (18:20 +0100)
committerMarge Bot <marge-bot@gnome.org>
Sun, 12 Feb 2023 20:02:34 +0000 (20:02 +0000)
ShellUserVerifier was connecting to UserVerifierChoiceList signals using
SignalTracker, but never disconnected those, leading to the
corresponding SignalTracker being leaked.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6395
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2637>

js/gdm/util.js

index 3d535659ce82fdba44c4592032580305c5abc9be..78c45cbbaa83fca000c5b23e2defc0e5f16dcb80 100644 (file)
@@ -520,6 +520,7 @@ var ShellUserVerifier = class extends Signals.EventEmitter {
 
     _disconnectSignals() {
         this._userVerifier?.disconnectObject(this);
+        this._userVerifierChoiceList?.disconnectObject(this);
     }
 
     _getForegroundService() {